search

pseudonym117 / Riot-Watcher

Simple Python wrapper for the Riot Games API for League of Legends
MIT License
531 stars 150 forks source link

Add Data Dragon versions endpoint. #200

Closed acgandhi closed 2 years ago

acgandhi commented 2 years ago

This gets a list of all of the valid versions for Data Dragon. https://ddragon.leagueoflegends.com/api/versions.json Pretty much just creates a versions_all method in DataDragonApi and the corresponding URL in DataDragonUrls. Also creates a test for the endpoint in test_DataDragonApi.

AFAIK this functionality wasn't previously implemented in Riot-Watcher.

codecov[bot] commented 2 years ago

Codecov Report

Merging #200 (f8a7ea1) into master (da95089) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   93.64%   93.67%   +0.02%     
==========================================
  Files          86       86              
  Lines        1039     1043       +4     
  Branches      156      156              
==========================================
+ Hits          973      977       +4     
  Misses         44       44              
  Partials       22       22
Impacted Files Coverage Δ
...otwatcher/_apis/league_of_legends/DataDragonApi.py 100.00% <100.00%> (ø)
...her/_apis/league_of_legends/urls/DataDragonUrls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da95089...f8a7ea1. Read the comment docs.