pseudonym117 / Riot-Watcher

Simple Python wrapper for the Riot Games API for League of Legends
MIT License
531 stars 150 forks source link

Adds Challenges API and tests #213

Closed Zackaryia closed 2 years ago

Zackaryia commented 2 years ago

Adds the Lol Challenges API to RiotWatcher as outlined in https://developer.riotgames.com/apis#lol-challenges-v1

codecov[bot] commented 2 years ago

Codecov Report

Merging #213 (f9d7a84) into master (3f8cf01) will increase coverage by 0.21%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   93.20%   93.41%   +0.21%     
==========================================
  Files          86       88       +2     
  Lines        1059     1094      +35     
  Branches      163      166       +3     
==========================================
+ Hits          987     1022      +35     
  Misses         47       47              
  Partials       25       25              
Impacted Files Coverage Δ
src/riotwatcher/LolWatcher.py 93.67% <100.00%> (+0.33%) :arrow_up:
...watcher/_apis/league_of_legends/ChallengesApiV1.py 100.00% <100.00%> (ø)
...rc/riotwatcher/_apis/league_of_legends/__init__.py 100.00% <100.00%> (ø)
...apis/league_of_legends/urls/ChallengesApiV1Urls.py 100.00% <100.00%> (ø)
...otwatcher/_apis/league_of_legends/urls/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f8cf01...f9d7a84. Read the comment docs.

Zackaryia commented 2 years ago

Solves #212

Zackaryia commented 2 years ago

@pseudonym117