search

pseudonym117 / Riot-Watcher

Simple Python wrapper for the Riot Games API for League of Legends
MIT License
532 stars 150 forks source link

Add support for start param in by_puuid function for MatchApi #217

Closed skyler1ackerman closed 1 year ago

skyler1ackerman commented 2 years ago

I want to be able to get more that 100 TFT matches, as I'm sure many people do. This isn't possible without changing the start param, so I added it. I threw in some docs while I was at it.

pseudonym117 commented 1 year ago

Update parameter order to ensure change is backwards compatible in case any other people were already calling without named parameters and fixed tests

codecov[bot] commented 1 year ago

Codecov Report

Merging #217 (7239eda) into master (2cc6001) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          88       88           
  Lines        1094     1094           
  Branches       79       79           
=======================================
  Hits         1022     1022           
  Misses         47       47           
  Partials       25       25
Impacted Files Coverage Δ
...c/riotwatcher/_apis/team_fight_tactics/MatchApi.py 100.00% <100.00%> (ø)
...cher/_apis/team_fight_tactics/urls/MatchApiUrls.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.