pseudonym117 / Riot-Watcher

Simple Python wrapper for the Riot Games API for League of Legends
MIT License
531 stars 150 forks source link

Package is not pep561 compliant #223

Closed ughstudios closed 1 year ago

ughstudios commented 1 year ago

https://peps.python.org/pep-0561/

Add a types-riot-watcher package, or a py.typed file.

pseudonym117 commented 1 year ago

Types exist on all deterministic values.

The design choice of allowing the deserializer init parameter allows users to change the return types of all API endpoint calls.

Maybe there is a way with generics to make this work at compile time, but it is non-trivial. As of now, all undocumented API endpoint return types are dict. If an easy way to handle this via generics exists, I can update, but currently I do not see a way to support while both: