search

pseudonym117 / Riot-Watcher

Simple Python wrapper for the Riot Games API for League of Legends
MIT License
531 stars 150 forks source link

Can't request for specific match type. #224

Closed pafi-code closed 10 months ago

pafi-code commented 1 year ago

There is a small change required in MatchApiV5.py.

The type argument should be changed to queueType following riot docs

Paulie-Aditya commented 11 months ago

can fix this, could I get this assigned?

pseudonym117 commented 10 months ago

As per https://developer.riotgames.com/apis#match-v5/GET_getMatchIdsByPUUID, the arguments are queue and type, not queueType.

Closing issue. If the official docs are incorrect, feel free to reopen.

pafi-code commented 10 months ago

So from the riot docs see the screenshot: image

I assumed the type keyword is supposed to be used for this?! Or did I misunderstand its usage?

When I tried it in my package lol-stats it always failed with keyword type. However when I changed it to queueType it worked.

BlossomiShymae commented 10 months ago

I believe that documentation is referring to the queue and queueType field for the League-v4 endpoint e.g RANKED_SOLO_5x5.

The argument type is referring to the values normal, ranked, etc. if I'm not mistaken. https://developer.riotgames.com/apis#match-v5/GET_getMatchIdsByPUUID

pafi-code commented 10 months ago

Okay I see. So I simply used wrong arguments for the keyword?! Luckily the API is documented so well... Thanks for clarification! I will try it when I have time and let you know if it worked for me.