search

pseudonym117 / Riot-Watcher

Simple Python wrapper for the Riot Games API for League of Legends
MIT License
532 stars 150 forks source link

API out of date #71

Closed 15ealbino closed 7 years ago

15ealbino commented 7 years ago

So on July 24, this API will be outdated, does anyone know how to change the version?

erickseolin commented 7 years ago

I am working on a update for the version 3 of the API: Riot Watcher I hope to finish it soon.

15ealbino commented 7 years ago

Thank you for your work.

On Tue, Jun 20, 2017 at 8:58 AM, Erick Seolin notifications@github.com wrote:

I am working on a update for the version 3 of the API: Riot Watcher https://github.com/erickseolin/Riot-Watcher I hope to finish it soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pseudonym117/Riot-Watcher/issues/71#issuecomment-309744963, or mute the thread https://github.com/notifications/unsubscribe-auth/AaK-e_PEoVzADfDyEb2_aN8elhaSBr3Wks5sF8H_gaJpZM4N_fSa .

pseudonym117 commented 7 years ago

I'm also working on updating the main repo to use the v3 apis. The work for just the v3 migration is almost done. But since the api can't be fully backwards compatible (due to riot removing bulk queries), I'm using this as an opportunity to make different improvements that are breaking changes.

If I manage to pull it off, it should add support for user defined caching and rate limiting, throughout the entire api, with some default implementations that make sense.

i32ropie commented 7 years ago

Hi @pseudonym117 How is the update going? If you want me to help you with the update you can chat to me at Telegram, my username is @Edurolp

Btw, I just got this message from RIOT tonight: image So if I can help you just tell me, I like your wrapper and I use it in my Telegram bot @LoL_bot

Good luck with the update! :1

pseudonym117 commented 7 years ago

experimental version of API update is pushed to branch api_v3_experimental. API changes are unfortunately breaking, but i am working on a backwards compatibility wrapper as i type this that will hopefully make the transition a bit less painful.

After finishing the backwards compatibility wrapper and double checking that all method names make sense, i will merge this branch to master and upload the project to pypi. likely will be done monday or tuesday.

pseudonym117 commented 7 years ago

fixed as of 54f3291