search

pseudonymous / better-better-booru

Various tweaks to make Danbooru better.
110 stars 41 forks source link

Resizing for screen #22

Closed Yoposoc closed 11 years ago

Yoposoc commented 11 years ago

When this option is ticked under BBB settings, it does not resize vertically, only horizontally.

ghost commented 11 years ago

As of the last version, the resize image option only mimicked Danbooru's resize behavior, which I believe still resizes by width only. In response to issue #20, the script has since been updated to allow for resizing by width only and resizing by width and height (a literal "resize to window"). Once I do something about issue #21 and do some actual testing, the next version should be released.

Something I'd like to check with you about is whether you know the "Logged Out Settings" section consists of options that only work when you're not logged into an account. While you're logged in, your actual account settings (fit images to window, default image width, blacklisted tags) are used. Is this clear enough or should I add a note to the logged out options that states this fact?

Yoposoc commented 11 years ago

So you're saying that when I'm logged in, any overlapping settings between the Danbooru account settings and BBB would mean that the Danbooru account settings would overrule the BBB settings?

ghost commented 11 years ago

Correct. For the "Logged Out Settings", any overlapping account setting would overrule the BBB setting. If there happen to be other overlapping settings not under the logged out section, the BBB settings would take precedence.

Maybe putting in an override account settings option wouldn't be a bad idea...

Yoposoc commented 11 years ago

Most people probably wouldn't know, so it's probably a good idea.

ghost commented 11 years ago

Notes added (for a while now) in what will be the next commit.