search

pseudonymous / better-better-booru

Various tweaks to make Danbooru better.
107 stars 41 forks source link

I guess I would describe my issue as "It just plain doesnt work" #28

Closed deathsheadknight closed 10 years ago

deathsheadknight commented 10 years ago

Installed it, restarted firefox, no effect. http://i.cubeupload.com/NsLki6.png

Edit: Oh, I just saw that Danbooru's update breaks this script. Ok, I guess I'll wait till there is a fix.

ghost commented 10 years ago

In your case, it's just that the script simply isn't working. For the update, the only real issue I've seen so far is broken thumbnails and images due to the removal of the file information from the API. It should still be generating something for you. At the very least it should be putting the "BBB Settings" option after "Forum" in your Danbooru menu bar.

I'm assuming Firefox and Greasemonkey are up to date and that you're using the latest version of the script? My first guess is going to be that you have localStorage disabled. The easiest way to tell is to open the error console (Tools -> Web Developer -> Error Console OR Control + Shift + J), select "Errors" to filter out everything else, load Danbooru with the script enabled, and look for an error that says "TypeError: localStorage is null".

fakkunamae commented 10 years ago

Uncaught ReferenceError: Danbooru is not defined chrome-extension://jnlnijmdloplkdnkdjpockjflbglmfgi/script.js:3761 Failed to load resource: the server responded with a status of 404 (Not Found) http://beacon-3.newrelic.com/1/fa197ca248?a=71204&be=4318&qt=0&ap=93&dc=285…%22rp%22%3A4091%2C%20%22rpe%22%3A7132%7D%2C%20%22navigation%22%3A%7B%7D%7D event.returnValue is deprecated. Please use the standard event.preventDefault() instead.

this is what i got, and I have been having this error on chrome and srware iron.

ghost commented 10 years ago

Ah damn. You know, I completely forgot about the possibility of loading the script as a standalone "extension" in Chrome. You're not using Tampermonkey, right? Without an extension that mimics Greasemonkey behavior, detecting/accessing the Danbooru JavaScript before injecting the script wouldn't normally be possible.

Try the following script and let me know how it works out for you: https://raw.github.com/pseudonymous/better-better-booru/chrome-testing/better-better-booru.user.js

I am a bit puzzled by the error though... All I'm doing is testing for the existence of Danbooru's JavaScript, so why is it returning an error when I'm not trying to access anything in it. The test should just silently fail. Without using Tampermonkey, the above script is working fine for me in Chrome.

EDIT: I guess using "typeof" is the correct way of doing a test for something that may not have been declared yet. Hm...

ghost commented 10 years ago

Do I scare people off or something? <_<

fakkunamae commented 10 years ago

nah, I'm just slow at replying, it worked like a charm as far as I can tell.

On Fri, Feb 28, 2014 at 9:47 AM, Moebius-Strip notifications@github.comwrote:

Do I scare people off or something? <_<

Reply to this email directly or view it on GitHubhttps://github.com/pseudonymous/better-better-booru/issues/28#issuecomment-36375828 .