search

pseudonymous / better-better-booru

Various tweaks to make Danbooru better.
110 stars 41 forks source link

Direct Download tags are rendered for blacklisted images #61

Closed throwaway002 closed 8 years ago

throwaway002 commented 8 years ago

This means that DownThemAll (for example) will also download blacklisted images, which likely is not what people want.

Tested with: Firefox 44.0.2

ghost commented 8 years ago

I suppose that thumbnails filtered out with the quick search should probably be omitted from the direct downloads as well. It should be fine If the blacklist and quick search change the direct download URLs of affected posts to "#" to disable the download and change it back to the file URL to re-enable it. As long as there aren't any unwanted side effects, it'll be faster than completely deleting/recreating the links each time some filter is toggled. I'll be rolling the idea around in my head at work today and start tinkering tonight.

ghost commented 8 years ago

Published my initial plan for disabling DDLs on filtered posts. If you'd like, you can test it out from the following link while I do my paranoid bug testing dance ritual before the official version release: https://github.com/pseudonymous/better-better-booru/raw/no-filtered-ddl/better-better-booru.user.js

Changes can be seen here: https://github.com/pseudonymous/better-better-booru/commit/22cc2bd4a848a0312fe3ff2fbae8ba4010eec722

throwaway002 commented 8 years ago

Works a treat, thanks.