search

pseudonymous / better-better-booru

Various tweaks to make Danbooru better.
107 stars 41 forks source link

Old post image doesn't load when using BBB #78

Closed fireattack closed 7 years ago

fireattack commented 7 years ago

One example: http://danbooru.donmai.us/posts/1762

Pretty sure it's because their URL structure (with /cached/) is slightly different from the new one, and BBB replaced them to a wrong one (not sure why it replaces the file even when "Disable Tagged Filenames" is disabled).

ghost commented 7 years ago

The posts have had their content rebuilt for a long time since it's the most straightforward and least "hacky" method of getting rid of event listeners attached to the replaced HTML elements. The only real problem is the new cached path that Danbooru started using at some point. I've made some updates that should fix the problems with viewing posts and hopefully let the direct downloads option work decently. You can try the current work in progress and let me know how it goes.

ghost commented 7 years ago

Thanks for the quick fix, I think it works now because I've bookmarked the dead images and it's loading fine now.

Edit1: some images won't load, I think it's because I'm opening too many pages but I never had this problem before.. however, the dead images load if I refresh again

ghost commented 7 years ago

Any news?

ghost commented 7 years ago

some images won't load, I think it's because I'm opening too many pages but I never had this problem before.. however, the dead images load if I refresh again

This is probably due to limitations on the Amazon bucket service that you're actually downloading the images through when dealing with cached images. I noticed the same problem when testing cached thumbnails. I've pushed version 7.4 so Greasy Fork should be officially updated to deal with the issue before too long.