search

pseudozach / nostr.directory

Find people you know from other social media sites on nostr
https://nostr.directory
MIT License
144 stars 11 forks source link

Please show all my follows' verified accounts #4

Open Giszmo opened 1 year ago

Giszmo commented 1 year ago

I want to

pseudozach commented 1 year ago

applied for twitter developer elevated access - pending twitter to approve it then I can release this feature.

Screen Shot 2022-12-25 at 10 22 57 PM

pseudozach commented 1 year ago

This is merged with https://github.com/pseudozach/nostr.directory/pull/6

Could sort by verified column to see only verified accounts.

Giszmo commented 1 year ago

Nice feature but the "Update contact list" is dangerous. It would trash most of my existing follows.

pseudozach commented 1 year ago

Why would it trash anything?

Giszmo commented 1 year ago

If I add some account to my list, it wants to publish an event that contains just that one account while I already follow 60 others. I would lose 60 follows to gain one?

This might be due to the use of differ relays.

pseudozach commented 1 year ago

That's a fair concern. Normally, I merge the contact list I find with the ones that are checked on the list. It might be better to first find out which relay the user is using and check their contact list from there.

Giszmo commented 1 year ago

"fair concern" sounds like it's only hypothetical. my nos2x plugin was asking me to sign an event that clearly would have unfollowed a bunch of accounts.

pseudozach commented 1 year ago

I could argue the reason you use an extension to sign for events is exactly for this reason. To check what you're signing and if you don't like it do not consent. I would also say we should make the extensions better so they surface more information regarding what the user is signing.

For the core of the issue, I need to implement a new approach such that we fetch user's relay list from their metadata, and then fetch their contact list from multiple relays, merge them and then offer to publish them. This might take some time. Meanwhile I've added a warning as well just so users are aware their contact lists getting messed up is a very real possibility.