search

psf / pyperf

Toolkit to run Python benchmarks
http://pyperf.readthedocs.io/
MIT License
782 stars 77 forks source link

Warn when bench command with `--tracemalloc` #130

Closed oraluben closed 2 years ago

oraluben commented 2 years ago

pyperf command only supports the --track-memory option, and not the --tracemalloc: https://github.com/psf/pyperf/blob/968f2474f8b4cf55bca2b90ce0f699ec371b1a66/pyperf/_command.py#L50

Do you think it's better to have a warning (or just a fatal) here?

vstinner commented 2 years ago

Do you want to propose a PR to implement this idea?

--tracemalloc is not usable with pyperf command.

oraluben commented 2 years ago

--tracemalloc is not usable with pyperf command.

Naturally. But I didn't realize that before digging into the code. Also, is there any doc specifying that?

Do you want to propose a PR to implement this idea?

I can do that.