search

psf / pyperf

Toolkit to run Python benchmarks
http://pyperf.readthedocs.io/
MIT License
771 stars 74 forks source link

gh-115: Migrate to the pyproject.toml #149

Closed corona10 closed 1 year ago

corona10 commented 1 year ago

closes: #115

CAM-Gerlach commented 1 year ago

As a general tip that even experienced folks often don't remember or aren't aware of, you can easily apply some or all suggestions directly in one go instead of repeating the same changes yourself manually, which can be time-wasting, tedious and error prone (as was the case here), by going to the Files changed tab, clicking Add to batch on each suggestion, and then clicking Commit to commit them all in one go. If you want to modify a suggestion or make your own, you can also easily do so in your own reply comment and add/apply that alongside the others. It also auto-resolves the relevant suggestions, clearly marks the relevant commits with the reviewer(s) whose suggestions were applied and can reduce the need for reviewers to manually recheck the changes, which makes things easier for reviewers, too.

corona10 commented 1 year ago

@hugovk @CAM-Gerlach

I apply most of your suggestions, would you like to take a look before merging this PR?

suggestions directly in one go instead of repeating the same changes yourself manually

Actually, it was intended after I met some messy cases, but I would like to try using the batch command as possible. Thanks for the suggestion.

CAM-Gerlach commented 1 year ago

Review in work now...

Actually, it was intended after I met some messy cases, but I would like to try using the batch command as possible.

Yeah, totally fine of course—I just know a lot of folks, even core devs, don't always know or remember this feature and as a reviewer I feel guilty when others, especially core devs like you, spend their valuable time implementing my suggestions. The other advantage for authors I didn't mention is that if something breaks with an applied suggestion, you know its the reviewer that messed up (as I all to often do :laughing: )

corona10 commented 1 year ago

Thank you @CAM-Gerlach @hugovk If there needs more improvement please let me know through the issue tracker :)