psf / pyperf

Toolkit to run Python benchmarks
http://pyperf.readthedocs.io/
MIT License
771 stars 74 forks source link

pyproject.toml: Add Python3.6 as available Python version #151

Closed corona10 closed 1 year ago

corona10 commented 1 year ago

We dropped the support for Python 3.6 through https://github.com/psf/pyperf/pull/142. Technically, it was available to be installed at Python 3.6 but since pyperformance still uses Python 3.6, I think that we should sync the version support with the pyperformance team.

There was a restriction at pyproject.toml but it was never published to PyPI yet luckily.

corona10 commented 1 year ago

cc @ericsnowcurrently @mdboom

corona10 commented 1 year ago

Option A

Option B

Option C

vstinner commented 1 year ago

The CI failed with:

ERROR: Could not find a version that satisfies the requirement setuptools>=61

Is it possible to use older setuptools on Python <= 3.6?

pyproject.toml contains:

[build-system]
requires = ["setuptools >= 61"]
build-backend = "setuptools.build_meta"

Why is version 61 required?

corona10 commented 1 year ago

Why is version 61 required?

I think that we can downgrade into 59

corona10 commented 1 year ago

@vstinner @ericsnowcurrently @mdboom

There looks some issue between the new package meta system with setuptools and Python 3.6 If we still need to support Python 3.6, I would like to suggest rollback the package build system into setup.py.

ericsnowcurrently commented 1 year ago

After thinking about it, I wouldn't worry about supporting 3.6.

vstinner commented 1 year ago

So pyperformance doesn't use Python 3.7 anymore?

corona10 commented 1 year ago

@vstinner we merged https://github.com/python/pyperformance/pull/249, so no support only for 3.6 not 3.7