search

psf / pyperf

Toolkit to run Python benchmarks
http://pyperf.readthedocs.io/
MIT License
785 stars 77 forks source link

Minor issue regarding memory units (kB vs KiB) #198

Closed yngvem closed 1 month ago

yngvem commented 1 month ago

The units in the output when track-memory is enabled say kB and MB. However, as far as I can tell, the correct units are KiB and MiB? It's a minor issue, and might not be worth changing due to the hassle of changing the output for downstream applications, but I found it confusing at first that the summary didn't match up with the actual numbers in the JSON file.

I wasn't sure if it was worth opening an issue for such a minor issue, but I thought it might be worth making a concious decision on whether to use precise SI units.

Sorry if there's already been a discussion on this, I tried looking but I couldn't find anything.

vstinner commented 1 month ago

Do you want to propose a pull request fixing the issue?

yngvem commented 1 month ago

I can give it a shot