search

psf / python-in-edu

website for educational python resources
http://education.python.org/
MIT License
41 stars 28 forks source link

Fix Nav Bar for Mobile - High Priority #36

Closed meg-ray closed 2 years ago

meg-ray commented 3 years ago

On mobile the (iOS & Chrome browsers) the menu in the Nav Bar does not persistently display, making only the homepage viewable on mobile.

lkuznia commented 3 years ago

I will take a look at this.

lkuznia commented 3 years ago

There is a conflict in the collapse functionality between the bootstrap and figuration libraries. Spoke with @meg-ray and I will try to remove the usage of bootstrap in favor of figuration.

salticus commented 2 years ago

tl;dr @birdcar (are you the right one to ping?) I would suggest closing this issue since it seems to be fixed on the running website.

The commit message on f43701f38d2d452f20e65912a78634205c7a0b3c, which is in the master branch, claims to have fixed this issue. On education.python.org the menus remain opened after tapping on the menu icon in the middle of the top bar on an iPhone 6s in both Safari and Chrome.

birdcar commented 2 years ago

@salticus thanks for the ping here, and sorry for missing it! I just dug myself out of a GitHub notifications hole. 🙇🏽

I don't know who the right person to ping here is, but I agree with you that this has been resolved. I have the ability to close this issue, so I'm going to go ahead and do it. Other maintainers can re-open if we discover that either you or I misunderstood the issue at play here and it wasn't fixed by f43701f