search

psf / requests-html

Pythonic HTML Parsing for Humans™
http://html.python-requests.org
MIT License
13.64k stars 977 forks source link

PYPI package #542

Closed gpongelli closed 1 year ago

gpongelli commented 1 year ago

Requests-html pypi package land to a fork of this project, where are published the wheel from this project ?

The project on PYPI has "bs4" dependency, it’s an inactive package not compliant with pep517 and led to sporadic build issue like:

Note: This error originates from the build backend, and is likely not a problem with poetry but with bs4 (0.0.1) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "bs4 (==0.0.1)"'.

If you need, I could contribute upgrading this project using recent tools like poetry, tox, GitHub actions, commitizen and others (I’ve made a cookiecutter templates for all of them), what do you think?

surister commented 1 year ago

I'd love to have your help. The github actions are almost ready, the last PR I did fixed few tests with the intention of setting up CI, I'm not sure about poetry, but If you could do the version thing, it'd be awesome. Let me know if you can help!

ammgws commented 1 year ago

Was maintainership of requests-html on pypi handed over to psf as well? Currently pypi lists kennethreitz and tuxtimi (@timofurrer) as maintainers, so I assume cannot yet make new releases there?

timofurrer commented 1 year ago

I was originally transferred maintainership of this from Kenneth. However, I'm not really working on this and I'm open to transfer ownership to someone from the PSF.

gpongelli commented 1 year ago

I'd love to have your help. The github actions are almost ready, the last PR I did fixed few tests with the intention of setting up CI, I'm not sure about poetry, but If you could do the version thing, it'd be awesome. Let me know if you can help!

Yes, I've already started adding poetry, but I'll open a new issue because of needed discussion on that topic.

Please share the github workflow, because with poetry and tox in place I'll need to change it.

surister commented 1 year ago

@timofurrer If you can yeah, please pass the pypi maintainership to either me or Ee Durbin (PSF director of Infra)

timofurrer commented 1 year ago

@surister What is Ee Durbins handle on pypi.org ?

surister commented 1 year ago

No clue, mine is @surister

timofurrer commented 1 year ago

@surister I've granted you maintainership.