search

psf / requests

A simple, yet elegant, HTTP library.
https://requests.readthedocs.io/en/latest/
Apache License 2.0
52.25k stars 9.34k forks source link

Installation of v0.10.1 on Windows 7 & Py2.5 fails - syntax error in utils.randombytes #427

Closed jqb closed 12 years ago

jqb commented 12 years ago

ver 0.10.1 contains new implementation of requests.utils.randombytes. line https://github.com/kennethreitz/requests/blob/v0.10.1/requests/utils.py#L185 causes an error on Windows 7 with Python 2.5.4

Older versions 0.10.0 & 0.9.x works.

kennethreitz commented 12 years ago

Python 2.5 is no longer supported.

drewyeaton commented 12 years ago

Why is 2.5 no longer supported?

Diaoul commented 12 years ago

I'd say because it's old, and prevents from using new stuff of 2.6+ versions.

jqb commented 12 years ago

Yep, but still there's a lot of code that runs on Py2.5. Sad but true. I guess I'll need to use older version to run it on Py2.5. Should I close an issue?

jezdez commented 12 years ago

@kennethreitz Hm, I thought you would consider adding Python 2.5 support again.. at least that's what I understood when I asked you about it regarding requests adoption in pip. Mind elaborating?

kennethreitz commented 12 years ago

I have no intentions of supporting Python 2.5 at this time. If pip decided to move to requests, I would revisit that ;)

jezdez commented 12 years ago

@kennethreitz Not sure what more is needed than a pip developer saying that requests adoption requires 2.5. A public statement?

kennethreitz commented 12 years ago

Start adopting it and I'll start putting 2.5 back in. It'll take half an evening :)

jezdez commented 12 years ago

Work on the adoption is being done as we write these silly messages, I've ported most of the PEP381 changes to requests. I need to test it on Python 2.5 though :)

kennethreitz commented 12 years ago

Fantastic :) I'll start to add 2.5 back in soon then.

kennethreitz commented 12 years ago

I lied.

jezdez commented 12 years ago

Obviously.

kennethreitz commented 12 years ago

:cake:

Lukasa commented 12 years ago

Should we move this discussion to a new issue? The name of this issue is totally misleading...

jezdez commented 12 years ago

@Lukasa Good idea +1