Don't create default SSLContext if CA bundle isn't present

psf / requests

A simple, yet elegant, HTTP library.

https://requests.readthedocs.io/en/latest/

Apache License 2.0

52.19k stars 9.33k forks source link

Don't create default SSLContext if CA bundle isn't present #6781

Closed AdamWill closed 3 months ago

AdamWill commented 3 months ago

Similar to e18879932287c2bf4bcee4ddf6ccb8a69b6fc656 , this also skips creation of the default SSLContext on FileNotFoundError, which is raised if DEFAULT_CA_BUNDLE_PATH does not exist.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2297632

nateprewitt commented 3 months ago

Hi @AdamWill, #6767 is likely the path forward at this point. We've found a number of sharp edges with the default caching behavior to a point it probably doesn't belong in Requests.

AdamWill commented 3 months ago

Ah, thanks, didn't see that one. I'll wait for it to be finalized then backport it. Thanks!