Add HTTP status group properties for response objects

psf / requests

A simple, yet elegant, HTTP library.

https://requests.readthedocs.io/en/latest/

Apache License 2.0

52.19k stars 9.33k forks source link

Add HTTP status group properties for response objects #6822

Closed vengatgs closed 1 week ago

vengatgs commented 1 week ago

PR Description:

This PR adds properties (is_2xx_successful, is_5xx_server_error, etc.) to the HTTP response class for easy classification of HTTP status codes, improving code readability.

Justification:

Improved readability: Using direct range comparisons like 100 <= self.status_code < 200 makes the code clear and intuitive.
Maintaining performance: The range comparison is efficient and keeps the performance trade-offs minimal while avoiding unnecessary complexity.

sigmavirus24 commented 1 week ago

No thank you. We're not expanding the API of Requests at this time and the freeze is well documented. Sorry you spent your energy on this