psferguson / chrysomallos

linking stars to observational selection functions through ssi
GNU General Public License v3.0
1 stars 0 forks source link

U/jcarlin/mv fix #15

Closed jeffcarlin closed 7 months ago

jeffcarlin commented 7 months ago

Standardized the use of "m_v" throughout the code for absolute V-band magnitude (i.e., "M_V"), and "stellar_mass" instead of "mass" for clarity.

Discovered that the total luminosity of stars being returned by MISTSersicSSPChrysomallos was lower than expected, because by default Artpop includes stellar remnants in the total mass. Added "add_remnants=False" to the call, and this makes the returned stellar luminosity more consistent with the requested M_V.

Added a unit test to confirm that the correct total luminosity is returned by adopt_a_cat when given different values of m_v.