Standardize luminosity variable

psferguson / chrysomallos

linking stars to observational selection functions through ssi

GNU General Public License v3.0

1 stars 0 forks source link

Closed jeffcarlin closed 7 months ago

jeffcarlin commented 8 months ago

Check all scripts/code and make sure they consistently use m_v (not M_V, Mv, etc.).

Add a unit test to check that m_v is being applied correctly. Stretch goal: include unit tests for all synthetic dwarf params.

psferguson commented 8 months ago

should sb_mv_to_rh be sb_m_v_to_rh or do we leave it?

psferguson commented 8 months ago

going to move unit tests out of this issue into their own

jeffcarlin commented 8 months ago

should sb_mv_to_rh be sb_m_v_to_rh or do we leave it?

I vote for leaving it -- I'm much more likely to remember it with mv and rh than with underscores.

psferguson commented 8 months ago

also in adopt a cat change mass to stellar_mass lines 92 and 98

psferguson commented 7 months ago