Remaining Squad Issues

[ScrawnyRonnie]

Listing some things that are still wonky with squads.

Disabled features:

• Promoting a new SL. This has caused an error of squad leader not found. No known reproduction steps.
• Squad searching. Could cause an error by attempting to return a squad that no longer existed. (might be resolved by #1157 already, but still disabled).

High:

• Sometimes (for reasons tbd) a client will crash or be kicked to the character select screen when the player joins a squad or views listed squads/clicks join for an open position.

Medium:

• Joining a squad while respawning or zoning will make squad UI elements never appear. Squad cards and numbers on map never show and the squad tab shows no squad members. Squad chat does work in this state and other players can see the player's card so the player is actually in the squad. Leaving and joining the squad while alive resolves it and UI elements appear.

Low:

• Squad cards remain on screen after a squad disbands or when you log back in if you were in a squad when you last logged out. Pressing Alt makes it go away and you are not actually still in the squad; just the UI stays for some reason.
• If player A is invited to multiple squads and A accepts player B's invite, player C that sent the other invite never gets an indication that player A joined another squad. If player A leaves the squad and player C tries to invite A again, A never receives the invite.

[ScrawnyRonnie]

Just adding some of the cursed behavior that sometimes happens the moment you join a squad, view listed squads, click into a squad to view available positions, or click join to request. Each of these things has your client receive a SquadDetailDefinitionUpdateMessage packet, and the cursed one has a lot of extra random things in it causing its size to be much larger than the usual packet of this name. There has been some discussion around squad index (the squads themselves and positions within a squad). From this last test after a server restart, only one squad had been created since the restart (confirmed from logs) and the position shown as available was accurate across all clients and this bug occurred.