pshergie / prator

Add review comments to your pull requests based on changes
22 stars 1 forks source link

Add file adding check #12

Open ai opened 4 months ago

ai commented 4 months ago

Someting like:

  - added: 'scripts/*.ts'
    message: 'Don’t forget to add docs to any script'
pshergie commented 4 months ago

I see why you may need it. I started to think about refactoring semantics in this way: to use different naming like modifiedPaths, addedPaths, and deletedPaths instead of just paths

ai commented 4 months ago

did you want to comment on this issue? https://github.com/pshergie/prator/issues/11

Oops, yes, removed.

But note, that we need some key which will combine modifiedPaths and addedPaths, to not duplicate file list every time

pshergie commented 4 months ago

I think the simplest solution here would be like this:

It doesn't solve the duplication problem but a trade-off would be a more complex config with logical operators, especially for cases like "I need that path to be commented on modification or addition but not on deletion".

pshergie commented 3 months ago

@ai do you think it's a good reason to call the updated functionality v2? The config I proposed wont be backward compatible (it's possible but it would be a dead code for those who use the updated version)

ai commented 3 months ago

Yes, config breaking changes need a major update