Open ai opened 4 months ago
I see why you may need it. I started to think about refactoring semantics in this way: to use different naming like modifiedPaths
, addedPaths
, and deletedPaths
instead of just paths
did you want to comment on this issue? https://github.com/pshergie/prator/issues/11
Oops, yes, removed.
But note, that we need some key which will combine modifiedPaths
and addedPaths
, to not duplicate file list every time
I think the simplest solution here would be like this:
allCasesPaths
: modifiedOnlyPaths
: addedOnlyPaths
:deletedOnlyPaths
It doesn't solve the duplication problem but a trade-off would be a more complex config with logical operators, especially for cases like "I need that path to be commented on modification or addition but not on deletion".
@ai do you think it's a good reason to call the updated functionality v2
? The config I proposed wont be backward compatible (it's possible but it would be a dead code for those who use the updated version)
Yes, config breaking changes need a major update
Someting like: