search

pshima / consul-snapshot

consul-snapshot is a backup and restore utility for Consul (https://www.consul.io). This is slightly different than some other utilities out there as this runs as a daemon for backups and ships them to S3. Also has integrated monitoring and backup health checks.
Apache License 2.0
116 stars 35 forks source link

Server side encryption #10

Closed mfischer-zd closed 8 years ago

mfischer-zd commented 8 years ago

As noted in commit comments.

Closes #9

pshima commented 8 years ago

This is awesome thanks for adding this @mfischer-zd (and for fixing the acceptance test filename).

Looks pretty straight forward, let me check a couple things (not sure how it reacts when those options are empty strings).

Also I need to check that the GetObjectInput doesn't need the SSE bits here: https://github.com/pshima/consul-snapshot/blob/master/restore/restore.go#L129 It seems like the API comments on get might be wrong via https://github.com/aws/aws-sdk-go/blob/master/service/s3/api.go#L5518

If all is well I will merge and cut a release.

mfischer-zd commented 8 years ago

I need to check that the GetObjectInput doesn't need the SSE bits

That's only necessary if a Customer Key is supplied. This patch doesn't provide such functionality, though it might be useful down the road.

pshima commented 8 years ago

Excellent, great. Will take a closer look as soon as I am able.

mfischer-zd commented 8 years ago

Also, before you cut a release, I'd like to address #11.