search

psi-4ward / docker-powerdns

PowerDNS Docker Image based on Alpine
107 stars 110 forks source link

Made mysql actually optional #5

Closed tcely closed 6 years ago

psi-4ward commented 6 years ago

Please review the commit and thanks for your investigation!

tcely commented 6 years ago

I'm not sure why you didn't just merge the commit from this PR. Either way though, your commit only closes PR #5.

psi-4ward commented 6 years ago

This is correct. The optimizations (ie exec sed only once) makes the script way more complicate to understand and I prefer a simply solution here.

I'll review PR #7 next week.