search

psi-im / psi

XMPP client
https://psi-im.org/
Other
404 stars 122 forks source link

Add an outline to the "Psi: Advanced" window #792 #818

Closed yatigautam closed 4 months ago

yatigautam commented 5 months ago

i have made some changes to the code file, margin adjustments are absolutely fine now let me know if any other changes are required.

Ri0n commented 5 months ago

I propose just not setContentsMargins(0, 0, 0, 0); inside the class but set outside just when the widget in the embedded mode. other changes are not needed.

The only thing I would also propose is setSpacing() for the filter line

yatigautam commented 5 months ago

i have understood the changes that are needed, will make the required changes and push them soon.

yatigautam commented 5 months ago

hello sir, i wanted to cross-check something, below i have attached some screenshots of the detached window, and it's not looking very well adjusted in minimized as well as maximized mode, i have made some changes and have those screenshots attached above, i think it would look more organized and adjusted if changed, what do you suggest? Screenshot (248) Screenshot (247)

Ri0n commented 5 months ago

Hi Yati, I'm sorry for intervening your work, but I just pushed to master the solution I described above. It looks good to me. You can checkout and learn from it.

yatigautam commented 5 months ago

sure sir.

Neustradamus commented 5 months ago

Thanks for your effort @yatigautam!

Original ticket is:

Solved by @Ri0n in this commit: