PGP message icon indicates plain text messages as encrypted

[Ri0n]

Original issue 589 created by psi-plus on 2014-06-13T10:12:43.000Z:

[11:38:21] <Hugin> i'm about to open a bug report about pgp message icons, and the bug tracker advises me to discuss it here first… [11:38:59] <Hugin> the little crypto lock in psi+ does NOT reflect whether the message received was encrypted or not; it reflects the internal state of the chat view only [11:39:39] <Hugin> pgp message icon := the arrow with the lock symbol on the left of a message [11:40:38] <Hugin> this bug leads to non-encrypted messages being claimed to be encrypted

What steps will reproduce the problem?

1. Enable options.pgp.auto-start (Not sure if this is needed in every case)
2. Start a new instance of Psi+
3. Receive a plain text message from a contact with an assigned OpenPGP-Key and a signed presence
4. This message will be claimed to be encrypted
5. Actually send something encrypted, followed by two plain text messages
6. The second plain text message will be claimed to be encrypted as well

What is the expected output? Plain text messages without lock symbol on the arrow

What do you see instead? Plain text message have a lock symbol on the arrow

What version of the Psi+/OS are you using? Psi+ 0.16.366 (2014-06-02) / Debian GNU/Linux unstable (sid)

Additional information: I've attached a screenshot and the corresponding XML log.

[Ri0n]

Comment #1 originally posted by psi-plus on 2014-06-19T19:48:45.000Z:

I've included a patch in Psi, which should fix the issue:

Psi branch: https://github.com/FlorianFieber/psi/tree/pgp_icons Psi+ fix: https://github.com/FlorianFieber/main/tree/upstream-fix

Someone willing to test and review it?

[Neustradamus]

@tehnick: Can you look this ticket?

Thanks in advance.