search

psi-plus / main

Main repository with patches and required resources
https://psi-plus.com/
GNU Lesser General Public License v2.1
68 stars 20 forks source link

Hide to tray is not working with XFCE virtual desktop setups #669

Closed ghost closed 6 years ago

ghost commented 7 years ago

Under following conditions hiding to tray by clicking tray icon is no longer working. However, selecting appropriate item ("Hide") from context menu is still working.

  1. Open psi-plus on virtual desktop number 1.
  2. Open some application (e.g. chromium or gnome-terminal) on another virtual desktop (number 2) in fullscreen mode.
  3. Hiding to tray is now broken until application on virtual desktop 2 quits fullscreen mode. With other applications like thunderbird hiding to tray is still working so I classifying it as psi-plus's bug. DE: Xfce WM: Xfwm4 Distro: Ubuntu 16.04 Psi-plus version: v0.16.568.604 (2016-10-22)
ghost commented 7 years ago

I highly suspect that this bug is DE-dependent.

Ri0n commented 7 years ago

What's your Qt version? (check this in help menu of Psi)

ghost commented 7 years ago

I'm using psi-plus from ppa:psi-plus/ppa on ubuntu xenial. Qt version is 4.8.7.

Ri0n commented 7 years ago

Hm I have tray problem on Xenial too. But different and with Qt 5.6. It even does not show up in tray. Sometimes some blank space is added.

If I use aproximatelly the same configuration on Gentoo Linux tray works perfect even when I have something in full screen on second monitor.

But all of this is on KDE. Xfce still uses Xembed tray implementation AFAIK. Xembed tray always worked good. So I can't say what could be wrong. I'll test when I have time for this.

ghost commented 7 years ago

I have something in full screen on second monitor.

Not exactly this. Second monitor is working fine. Virtual desktop (workspace) on the same monitor is the problem.

ghost commented 7 years ago

I built from git with Qt 5.5.1 and problem remains.

ghost commented 7 years ago

Xfce still uses Xembed tray implementation AFAIK.

Appindicator is also supported in latest xubuntu.

ghost commented 7 years ago

But all of this is on KDE.

It works on KDE for me too. Should be XFCE-specific.

ghost commented 7 years ago

Problem still remains for me with Psi+ v0.16.572.639-webkit (2017-02-27) Qt 5.5.1 on Xfce4

Ri0n commented 6 years ago

I was able to reproduce the issue with xfce. qt-5.10.

broken in Psi+ only. Psi works fine.

Ri0n commented 6 years ago

most likely 0120-psi-tray-act-bring-to-front.diff breaks things returning invalid result from X11WindowSystem::isWindowObscured

Vitozz commented 6 years ago

Delete this useless patch

Ri0n commented 6 years ago

The reason why this patch at all exists https://code.google.com/archive/p/psi-dev/issues/300

Ri0n commented 6 years ago

as a workaround, just disable options.ui.contactlist.raise-inactive option.

Ri0n commented 6 years ago

fixed by d911875c8034f48b2ae477919b2eabfdc0d6f60e