search

psi-plus / main

Main repository with patches and required resources
https://psi-plus.com/
GNU Lesser General Public License v2.1
68 stars 20 forks source link

Option to disable "message correction" or reassign from Ctrl+↑ #688

Open grompe opened 7 years ago

grompe commented 7 years ago

I regularly use Ctrl+↑ to resend undelivered messages or to send copies of previous messages. This feature breaks my workflow.

Ri0n commented 6 years ago

send copies? for what?

regarding undelivered, I believe you mean ones not reached even your server because of some connection failure from your side. Otherwise it's a problem of your server to deliver your messages. Of course it's possible you are talking about message carbons and you resend a message just ensure it's delivered to another device if the device wasn't online before.

In any case there is nothing regular here. Ctrl+↑ is very common correction hotkey for some other clients. It will be kept untouched. And I don't see any imposing reason to disable this feature.

Instead I propose some more complicated shortcut to retrieve input history without correction. For example Ctrl+shift+↑. Of course if there is anyhow nothing to correct Ctrl+↑ will do the same.

tehnick commented 6 years ago

Please do not use Ctrl+Shift+\<Key> shortcuts. They may conflict with Ctrl+Shift shortcut for language switching in X11 environment.

Ri0n commented 6 years ago

shift+up?

tehnick commented 6 years ago

Yep.

grompe commented 6 years ago

send copies? for what?

For example, I posted an URL in a groupchat some time ago. Somebody new comes in, it's easiest for me to bring up an old message, slightly edit it and send again. Suddenly, now it's regarded as an edit of an old message supporting clients won't even see.

regarding undelivered [...] it's a problem of your server to deliver your messages.

Not everyone uses servers with latest features or has perfect connection. A user lost connection, but stays "online" 5 minutes before has a timeout, any messages sent to them in that interval simply disappear.

Ctrl+↑ is very common correction hotkey for some other clients

I'd rather you keep compatibility with UX of older versions of Psi+ than some other clients I don't use. At least making an option is sensible solution. If you simply change the interface under the user, it just motivates not to update Psi+ ever.

Ri0n commented 6 years ago

You know what.. I'll change it to have the same behavoir like in Telegram. You will be happy with that. In other words if input field is empty and you press just <↑> then this is message correction. For ctrl+↑ it will be just input history.

Ri0n commented 6 years ago

regarding your example with groupchat it's very very rare case. There are two cases usually. Your message is still in recent muc history, so new-comers already see it. You talk with others so the chance you still have input history for the specific stuff is quite low at the moment someone new asks for this. :-)

ValdikSS commented 6 years ago

In other words if input field is empty and you press just <↑> then this is message correction. For ctrl+↑ it will be just input history.

That looks sane.