psi-plus / main

Main repository with patches and required resources
https://psi-plus.com/
GNU Lesser General Public License v2.1
68 stars 19 forks source link

annoying "You are in or joining this room already!" message boxes #690

Open p5n opened 7 years ago

p5n commented 7 years ago

I use libpurple skype transport which keeps connection to skype while jabber client disconnected. When I connect jabber client it produces tens and hundreds of mesageboxes because of there are number of bookmarked skype's MUCs that I already joined.

I just commented this out

diff --git a/src/mucjoindlg.cpp b/src/mucjoindlg.cpp
index 244c3e8..1a1d4e8 100644
--- a/src/mucjoindlg.cpp
+++ b/src/mucjoindlg.cpp
@@ -221,7 +221,7 @@ void MUCJoinDlg::doJoin(MucJoinReason r)

        if (!account_->groupChatJoin(host, room, nick, pass, !ui_.ck_history->isChecked())) {
-               QMessageBox::information(this, tr("Error"), tr("You are in or joining this room already!"));
+//             QMessageBox::information(this, tr("Error"), tr("You are in or joining this room already!"));
                return;
        }

Another solution is do not retry autojoin-bookmarks on such failures, so it will produce only 1 messagebox per MUC bookmark with join=autojoin property.

Neustradamus commented 4 years ago

@p5n: Always here?

p5n commented 4 years ago

currently auto-join to skype muc does not work at all

p5n commented 4 years ago

Hmm, after 20 minutes psi opened hundreds of messageboxes, so this bug is still actual.