psi-plus / main

Main repository with patches and required resources
https://psi-plus.com/
GNU Lesser General Public License v2.1
69 stars 20 forks source link

FR: X-obb tag #723

Closed gerroon closed 2 years ago

gerroon commented 6 years ago

Hi

This is based ona bug I opened with Conversation team. Basically uploads are not "uploaaded" to mesages properly.

FR: Parse image urls as inline images See @iNPUTmice's reply/

https://github.com/siacs/Conversations/issues/3049

dos1 commented 6 years ago

https://github.com/psi-im/plugins/commit/70ce2db01d06629c5753a920dfd813c5fd42921b ? Which version are you using?

gerroon commented 6 years ago

@dos1

I use

Psi+ v1.3.287 (2018-03-10, Psi:eac157d1, Psi+:0b7b7f6)

dos1 commented 6 years ago

So update it - it's already fixed since April 8.

gerroon commented 6 years ago

@dos1

Thanks I am using it on Debian Testing. I will wait until a new release.

https://tracker.debian.org/pkg/psi-plus

Thanks for the fix.

gerroon commented 6 years ago

@dos1

In which version is this fixed? I installed 1.3.355 and still not working

thanks

gerroon commented 6 years ago

Ok I was mistaken, it works only one way meaning that uploads from Psi+ to Conversations work but from Conversation to Psi+ uploads looks like plaintext in this format in the message window

aesgcm://MYDOMIAN.com:PORT/upload/5ac7d44f1c8628be13ee801828a7b6adceeb03f4/PhOQ7BuFI0gfRNU9kmHbEVvZPcx89xLi3vmoSp6o

dos1 commented 6 years ago

That's a completely different, unrelated issue: aesgcm:// URIs are for files encrypted with OMEMO. Make sure you have your OMEMO plugin enabled and up-to-date.

gerroon commented 6 years ago

@dos1

Thanks for the info. Are these uploads from Psi+ encrypted (with omemo, assuming clients accept eachother) as well like Conversation does?

dos1 commented 6 years ago

From a quick glance to the code, I don't think so.

gerroon commented 6 years ago

@dos1 thanks for the follow up.

Shall I open a request ticket?

Neustradamus commented 2 years ago

@gerroon: Any news about it?