search

psi-plus / main

Main repository with patches and required resources
https://psi-plus.com/
GNU Lesser General Public License v2.1
69 stars 20 forks source link

Service discovery: Unexpected refresh #807

Closed sjehuda closed 1 month ago

sjehuda commented 2 months ago

Service discovery refreshes itself unexpected upon change window focus (see second 7 to video) or upon first click (see second 27to video).

psi_service_discovery-2024-04-26_17.29.47.webm

Reported by @Neustradamus

Neustradamus commented 2 months ago

@sjehuda: Thanks for your video!

@Ri0n: When we click on "+" a first time, it is refreshed, and we need to click a second time on "+" to see the details.

Solution is to remove the first refresh to have directly selected details

Linked to:

lao-mang commented 2 months ago

несколько раз замечал

sjehuda commented 2 months ago

I am curious to know what exactly happens which causes this double refresh in Service Discovery.

I am not coding in C++, yet I sense that knowing about this process might give a good understanding of handling Service Discovery, which I consider an important feature for every XMPP client.

Neustradamus commented 2 months ago

I think it has been solved with this commit, thanks to @Ri0n:

Psi+ 1.5.1873:

sjehuda commented 1 month ago

Service Discovery appears to work as expected.

Shall we close this ticket?

Thank you to @Neustradamus for petitioning me several times already to test this issue; I definitely needed that ';-)