Closed loriab closed 2 years ago
Base: 84.01% // Head: 84.00% // Decreases project coverage by -0.01%
:warning:
Coverage data is based on head (
f58e174
) compared to base (765fe07
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I was looking at the docs build fail over at the psi4 PR, https://github.com/psi4/psi4/actions/runs/3154641501/jobs/5132460787#step:9:9 (message copied below)
It's the only CI track that's building optking from src rather than using the c-f package. So one fix would be to edit
docs-cf.yaml
and switch to the conda pkg. Or we could use this as an opportunity to appease Py packaging and fix the message above. Firstly, like much of Py packaging I don't really understand the message above or why there are so many tools for essentially a copy-paste operation or why they keep changing/developing it. I just play along. I think the proposed changes in this PR might squelch the message (maybe will need another dunder init in tests/psi4file/psi4psithon, too). If you want, you could edit in the psi4 the external/optking/CM file and replace "master" with "loriab-patch-1" to try this out. Another workaround would be to not have tests as an importable module (that is, remove tests/init.py). I've had good success with this at Psi4 when it started complaining alot about tests with the same name. Caveat is that you need to require pytest >=7 and use a special mode, https://github.com/psi4/psi4/blob/master/pytest.ini#L2-L9 . You can still import utilities fns for tests but it'd befrom util import fn
, notfrom ..util import fn
.Anyway, those are a few guesses at forward paths. Let me know if I can be any help.