psi4 / psi4numpy

Combining Psi4 and Numpy for education and development.
BSD 3-Clause "New" or "Revised" License
337 stars 157 forks source link

Fresh PR for polariton-cq #116

Closed FoleyLab closed 3 years ago

FoleyLab commented 3 years ago

Incorporates changes suggested by @loriab and @dgasmith and omits extra files accidentally incorporated in the SCF/ folder.

Description This pull request provides reference implementations of hybrid ab initio / cavity quantum electrodynamics methods for computing mean-field ground- and excited-states of molecules strongly coupled to a single quantized photon. What are your new additions? Please provide a brief list.

FoleyLab commented 3 years ago

lgtm! but did the Polaritonic-Quantum-Chemistry dir not get a file like https://github.com/psi4/psi4numpy/blob/master/tests/test_RI_CC.py so that the scripts in this PR get tested?

@loriab thank you! I just added test_RI_CQEDQC.py to the tests directory that will run CQED_RHF.py and CS_CQED_CIS.py.

dgasmith commented 3 years ago

Thanks @FoleyLab , apologies the review was pretty slow here- this method is a bit outside of wheelhouse!