psi46 / pxar

Life is too short for perfection
16 stars 46 forks source link

Add checkbox to enable FLAG_FORCE_UNMASKED in PixelAlive #141

Closed simonspa closed 10 years ago

simonspa commented 10 years ago

Reason: then exactly this test can be used to run Xray Highrate Efficiency Hitmap tests with the full chip unmasked and exposed to xray background.

ursl commented 10 years ago

I don't think this is sufficient. More code changes are needed for that. Just unmasking the entire ROC would lead to a quasi-random "hitmap"/"efficiency" map, as additional hits will be present from the xray source. I rather think that for this test we must histogram only the pixel that got the calibrate, and we must make sure that they are the correct ones (similar to the address decoding test).

On Wed, May 21, 2014 at 1:58 PM, simonspa notifications@github.com wrote:

Reason: then exactly this test can be used to run Xray Highrate Efficiency Hitmap tests with the full chip unmasked and exposed to xray background.

— Reply to this email directly or view it on GitHubhttps://github.com/psi46/pxar/issues/141 .

ursl commented 10 years ago

This is now in PixTestHighRate, modulo issue https://github.com/psi46/pxar/issues/171