search

psi46 / pxar

Life is too short for perfection
16 stars 46 forks source link

Changes in PhOpt Test considering suggestions from DESY. #410

Closed dehuazhu closed 9 years ago

simonspa commented 9 years ago

Does not even compile. Header file not committed probably. https://travis-ci.org/psi46/pxar/jobs/83320545#L465

ursl commented 9 years ago

No, my first guess would be that the migration of the declaration (definition?) of badpix into a for loop implies that it goes out of scope after the for loop.

But the conclusion is clear: very bad.

Though shalt not commit/push untested code.

Cheers, --U.

On Fri, Oct 2, 2015 at 8:01 PM, simonspa notifications@github.com wrote:

Does not even compile. Header file not committed probably. https://travis-ci.org/psi46/pxar/jobs/83320545#L465

— Reply to this email directly or view it on GitHub https://github.com/psi46/pxar/pull/410#issuecomment-145105456.

simonspa commented 9 years ago

Uh, @ursl obviously you are right, I didn't even read that far... :)

simonspa commented 9 years ago

new PR #411