search

psi46 / pxar

Life is too short for perfection
16 stars 46 forks source link

Changes in PixTestReadback for improved calculation of the patter period. #414

Closed dehuazhu closed 8 years ago

dehuazhu commented 9 years ago

This pull request, created together with Pirmin, suggests changes in the Readback Calibration Test.

  1. The main purpose is to calculate the pattern generator (PG) period, as well as the PG-"delays" in a more general way. This will allow a more reliant test with ROCs and a higher adaptability to changes in pxar core.
  2. The whole process of preparing the PG is now only in PixTestReadback::PreparePG(), instead also partly in PixTestReadback::setTrgFrequency(), which is not being used anymore.
  3. Added more DEBUG-logs and DEBUGAPI-logs while reducing INFO-logs making a more efficient parsing of logfiles. Especially more transparency in understanding how the PG is configured and how the PG-period is being calculated.

This change of code was successfully tested on two digv21respin ROCs as well as M2092, M2052 and M2053.