search

psibi / download

High level download interface for Haskell
https://www.stackage.org/package/download
Other
10 stars 3 forks source link

feed dependency #14

Closed dzhus closed 7 years ago

dzhus commented 7 years ago

Hi,

It looks like the latest version of download currently published on Hackage has a dependency on feed package without an upper bound specified.

A new version of feed will be released soon, incorporating non-backwards compatible changes to feed interface (String was replaced with Text throughout and xml-types types were adopted). Changes are largely mechanical but you'll probably want to ensure that future version of download can build with newer feed.

To prevent breakage, you may want to release a new version of download with an upper bound specified now, then push a version compatible with feed-1.0 after that comes out later.

Use the tip of the feed PR to test your package against: https://github.com/dzhus/feed/commit/259bab0. Please report any issues to the aforementioned PR thread.

psibi commented 7 years ago

String was replaced with Text throughout

Are you sure ?

download just uses parseFeedString function and I'm sure it's present in the newer release of the library: https://www.stackage.org/haddock/nightly-2017-09-07/feed-1.0.0.0/Text-Feed-Import.html#v:parseFeedString

So, I guess I'm safe ?

dzhus commented 7 years ago

@psibi If so then yes, you're safe - that function should still work

psibi commented 7 years ago

Thanks!

On Fri, Sep 15, 2017, 8:08 PM Dmitry Dzhus notifications@github.com wrote:

@psibi https://github.com/psibi If so then yes, you're safe - that function should still work

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/psibi/download/issues/14#issuecomment-329801415, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtAxbzSt2QnYtSbfM5jwGKBIvd4ul1Qks5siovYgaJpZM4PBc1v .