psibi / justl.el

Major mode for driving just files.
GNU General Public License v3.0
65 stars 13 forks source link

justl-exec-recipe-in-dir doesn't seem to use justl-compile-mode #24

Closed treed closed 2 years ago

treed commented 2 years ago

I came here to ask for the justl-compile-mode feature and found that it had already been implemented, which is cool!

However, it seems not to work with justl-exec-recipe-in-dir. Perhaps I'm just missing something, but it would be nice to have justl-complie-mode work with both methods of interaction. :)

psibi commented 2 years ago

Yeah, good catch. It has been quite some time since I used justl-exec-recipe-in-dir as I have been using the justl way of interacting with it.

This should be relatively simple to fix, I will see if I can get to it soon.

psibi commented 2 years ago

Also, if you would want to send a PR, that's welcome too. :-)

psibi commented 2 years ago

@treed Can you see if this works for you: https://github.com/psibi/justl.el/pull/25 ?

treed commented 2 years ago

Yeah, this looks like it works, thanks!

I toyed around with it some but wasn't sure about what to pass for the directory. Glad to know I was on the right track at least.

psibi commented 2 years ago

Thanks for the confirmation!