psibi / justl.el

Major mode for driving just files.
GNU General Public License v3.0
65 stars 13 forks source link

Fix just executable argument positioning when setting custom flags #39

Closed johnhamelink closed 1 year ago

johnhamelink commented 1 year ago

This commit changes the justl--parse and justl-exec-eshell functions so that arguments are ordered correctly when calling just: arguments which are destined for just (as in the executable) should be defined before the recipe, since the recipe can have its own arguments.

johnhamelink commented 1 year ago

Umm, when I run ERT locally it passes - is there something wrong with CI?

Screenshot 2023-08-30 at 20 07 16

psibi commented 1 year ago

Umm, when I run ERT locally it passes - is there something wrong with CI?

Don't think so, since it passes in master branch: https://github.com/psibi/justl.el/actions/runs/5921611832/job/16054384296

johnhamelink commented 1 year ago

Ok, maybe my Emacs' state was incorrect, I Will have a look tomorrow evening if I get a chance!

johnhamelink commented 1 year ago

@psibi fixed! I fixed it by accident while thinking about #43

psibi commented 1 year ago

Thank you!