Major PR: A lot of changes

psibi / streamly-bytestring

BSD 3-Clause "New" or "Revised" License

9 stars 8 forks source link

Major PR: A lot of changes #1

Closed adithyaov closed 4 years ago

adithyaov commented 4 years ago

Update modules with proper name convention.
Update functions and tests with the proper name conventions.
Update modules to work with the latest Streamly on Github HEAD.

@psibi Thank you for agreeing to maintain this repository. Please go through the changes and let me know any improvements/changes. Constructive criticism is always appreciated. If possible, could you please add me as a maintainer to this repository.

harendra-kumar commented 4 years ago

I prefer the original module names to the Conversion name space, but it's okay I guess. Any other ideas? @harendra-kumar

Let's not introduce a Conversion namespace. We can use the same naming as we use in Streamly, so this would be Streamly.Memory.ByteString as it uses pinned memory.

adithyaov commented 4 years ago

Please ignore the last reference.

adithyaov commented 4 years ago

@harendra-kumar You can take a look at this PR. Please note the following changes that have to be made:

Version streamly (After the release)
Fix cabal builds. Will be fixed automatically after the next release of streamly. I could probably include a cabal.project file to look for streamly HEAD. but I'll remove that anyway after the next streamly release.
Remove extra-deps from stack.yaml file
Modify Readme: Change ready, will push it along with the rest of the changes.

harendra-kumar commented 4 years ago

@psibi / @adithyaov I think we can merge this for now and make any other changes using other PRs, @hasufell is waiting for the change for quite some time now.

psibi commented 4 years ago

@harendra-kumar Sure, let me merge this then.

hasufell commented 4 years ago

will there be a release?

adithyaov commented 4 years ago

@hasufell Yes, after 1 final check/change, hopefully by tomorrow.