Closed ghost closed 5 years ago
Thanks!
Glad that I could help. On Nov 18 2018, at 10:22 pm, Sibi notifications@github.com wrote:
Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/1542579288.local-056ff2ab-0b30-v1.5.2-31660462@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Fpsibi%2Ftldr-hs%2Fpull%2F14%23issuecomment-439688836&recipient=cmVwbHkrMDI0OGYyNmQ2OGY4OTlmMTA4NjczYWNmYjg4NDI4N2FlZTc0OGM0ZmU5YTE4NmY3OTJjZjAwMDAwMDAxMTgwOTFiODg5MmExNjljZTE2YzNlNjliQHJlcGx5LmdpdGh1Yi5jb20%3D), or mute the thread (https://link.getmailspring.com/link/1542579288.local-056ff2ab-0b30-v1.5.2-31660462@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkjybUpS1Gib3wTko4AnkX6cp-QjL17Zks5uwVEIgaJpZM4Yn0x_&recipient=cmVwbHkrMDI0OGYyNmQ2OGY4OTlmMTA4NjczYWNmYjg4NDI4N2FlZTc0OGM0ZmU5YTE4NmY3OTJjZjAwMDAwMDAxMTgwOTFiODg5MmExNjljZTE2YzNlNjliQHJlcGx5LmdpdGh1Yi5jb20%3D).
The problem
I noticed that
checkDirs
(inapp/Main.hs
) only contains thecommon
,linux
andosx
directories, but not thewindows
directory:However, both
stack
andghc
have support for Windows; even thoughtldr-hs
will compile on Windows, it won't use the Windows specific pages. This PR aims to solve that problem.The solution
The result is changing
checkDirs
from it's previously stated definition to:and changing
getPagePath
, from:to:
Status
This solution works perfectly fine on my
Ubuntu 18.04.1
machine:(both
assoc
andcls
are in thewindows
pages directory;adduser
is merely used to show that pages from other directories still load).