search

psibi / tldr-hs

Haskell tldr client
BSD 3-Clause "New" or "Revised" License
92 stars 14 forks source link

Fix background colors #3

Closed alx741 closed 7 years ago

alx741 commented 7 years ago

So I'm using solarized-light color scheme, and for me it looks like this:

After this fix, it looks right:

I also test it with a dark background, and it works fine:

Making fgColor = Black and bgColor = White wouldn't work, the reason is that what the terminal's color pallette white is, may or may not be what the background color is. So the result ends up looking wrong again:

I can't think of a case on which one would like to have the background of the printed out text to be different to the terminal's background color, hence the fix.

psibi commented 7 years ago

@alx741 Thanks for the fix. Can you update the changelog and bump the version to 0.2.1 ? I will merge this once the Travis passes.

alx741 commented 7 years ago

Sure thing

psibi commented 7 years ago

Thanks. Have released a new version with your changes.