psifidotos / applet-window-buttons

Plasma 5 applet in order to show window buttons in your panels
GNU General Public License v2.0
403 stars 56 forks source link

Button color for inactive windows on multiple screens #46

Closed ishovkun closed 5 years ago

ishovkun commented 5 years ago

Some themes (like e.g. SierraBreeze) vary the button color when the window is active/inactive. This is very convenient for identifying the active window. The window-buttons applet does not support it, which inhibits the experience in multi-monitor setup. In plain English: I have three screens and each has a maximized window. I'd like the applet to change the button colors for inactive windows so I can see which window has the focus.

Screenshot_20190822_124308

psifidotos commented 5 years ago

Last time that was supported it broke the entire buttons experience because underlying plasma decorations produce errors

ishovkun commented 5 years ago

AWC hides the buttons when a screen with a maximized window doesn't have the focus. Can that be implemented instead?

psifidotos commented 5 years ago

Probably it might be a good idea to add in settings :

and the user can choose what suits him best

psifidotos commented 5 years ago

Just checked that the filter by screen option exists already, have you enable it?

ishovkun commented 5 years ago

Yes, I have that enabled. I also got show when active window is maximized enabled. Therefore, when I switch to another screen, the buttons in the inactive screen with a maximized window are shown. That confuses me because I cannot say which screen has focus.

psifidotos commented 5 years ago

Plasma panel or Latte panel?

psifidotos commented 5 years ago

Please make also a screenshot of the applet settings to try to reproduce in my system. If you have screens filter enabled then if the active window is another screen then the window buttons should not be

psifidotos commented 5 years ago

shown. Sounds like a bug.

ishovkun commented 5 years ago

It's Latte. Screenshot_20190822_173154

ishovkun commented 5 years ago

In the screenshot I'm showing that all three window button applets are showing buttons even though there is only one window is active at a time. I'd like the buttons to be indicative of which screen I need to be looking at.

psifidotos commented 5 years ago

Show me a screenshot of Window buttons applet settings please

psifidotos commented 5 years ago

@ishovkun the issue for NOT hiding buttons in different screens is CONFIRMED and fixed through #47

But I think you are right the DISABLED buttons is ALSO a good idea to add as an option the needs are the following:

psifidotos commented 5 years ago

@ishovkun feel free to report back if everything is ok now... I added two new options:

image

ishovkun commented 5 years ago

Works like a charm. You rock!