psifidotos / applet-window-buttons

Plasma 5 applet in order to show window buttons in your panels
GNU General Public License v2.0
403 stars 56 forks source link

Change to small resolution get a size problem #52

Closed buntupana closed 5 years ago

buntupana commented 5 years ago

I have a 2560x1440(QHD) resolution monitor, when I switch to a 1920x1080(FHD) TV, the size of the icons are way bigger and the margins does not match properly with the panel. I'm using a scaling factor of 1.4

scaling_0

image

image

image

psifidotos commented 5 years ago
  1. If you close Latte and restart it the problem remains?
  2. If you make the thickness margin 0px. the problem remains after you restart Latte?
buntupana commented 5 years ago

1.- If you close Latte and restart it the problem remains?

scaling_2

Restarting solve the problem partially because the applet is keeping the pixel margins with the new resolution and it makes the buttons too small.

2.- If you make the thickness margin 0px. the problem remains after you restart Latte?

scaling_3

psifidotos commented 5 years ago

Ok so this is not applet fault. The applet does not paint the buttons, the buttons are painted from each decoration used, the applet just provides the space in which the buttons must be painted. In your case the decoration used is Breeze, so I believe something breaks with Breeze.

I will leave it open in case any more findings are found.

buntupana commented 5 years ago

It would be really nice to have a relative size for the margins like in latte dock, in that way if I change resolution the buttons will have the same size. Or mabye have to option to have the buttons with the same size that we have in the window (I don't know if this is possible to implement)

psifidotos commented 5 years ago

Having relative icon size based on the panel thickness it is possible, but that wouldn't solve the mentioned issue.

Having an option for the same size with the window decoration is not possible because decorations do not expose that.

buntupana commented 5 years ago

it wouldn't solve the issue but at least it will have the same size after restart latte dock :)

psifidotos commented 5 years ago

try latest master... I introduced a button size percentage and at the same time checked out its behaviour when changing screen resolutions, it worked without issues...

image

buntupana commented 5 years ago

Cool, it works. Thank you so much. Btw, which decoration do you use?

psifidotos commented 5 years ago

Breeze

buntupana commented 5 years ago

I've changed the decoration and after that I've changed again to Breeze and it works perfectly without the size problem. Now with that and your change it works perfectly.

Btw, which distribution do you use? Sorry to bother with such a lot of questions :D

psifidotos commented 5 years ago

I use Opensuse Tumbleweed