psifidotos / kwin-script-workflow

This is an effort to create a KDE KWin script that integrates the main Activities, Virtual Desktops and Tasks Functionalities from Plasma Desktop in just one component.
http://workflow.opentoolsandspace.org/
GNU General Public License v2.0
5 stars 2 forks source link

Trigger shortcut not changed #2

Open bmihaila opened 11 years ago

bmihaila commented 11 years ago

Hi

Tried the script now again using the dedicated plasmoid for it and love it more and more :). I switched from opengl to raster in kwin and now it seems fast enough so the script is finally usable for me. Think I will switch to the kwin script + plasmoid instead of the original workflow plasmoid.

Some things though, as always. You mention on the here: http://kde-look.org/content/show.php/WorkFlow+KWin+Script?content=157726

-- added an inline configuration dialog in order to set some settings (the settings can not be stored yet so they are per kwin session)

So all the settings are lost on relogin currently?

But the main thing is that I tried to change the shortcut to trigger the script to something else from the right-click menu of the plasmoid and it does not work. So at the moment I can only use the Ctrl+Meta+Z shortcut. How to change it?

psifidotos commented 11 years ago

Στις 23/03/2013 02:40 μμ, ο/η Bogdan Mihaila έγραψε:

Hi

Tried the script now again using the dedicated plasmoid for it and love it more and more :). I switched from opengl to raster in kwin and now it seems fast enough so the script is finally usable for me. Think I will switch to the kwin script + plasmoid instead of the original workflow plasmoid.

Nice to hear... :)

Some things though, as always. You mention on the here: http://kde-look.org/content/show.php/WorkFlow+KWin+Script?content=157726

-- added an inline configuration dialog in order to set some
settings (the settings can not be stored yet so they are per kwin
session)

So all the settings are lost on relogin currently?

Well yes but it is not my fault... :) there are some things missing in KWin Scripting implementation, for example writeConfig or a Config dialog. It would be a good idea to open issues which are KWin Scripting related and open bugs or feature requests in bugs.kde.org in order to follow their progress if any.. I am very optimistic that now that WorkFlow KWin script exists it will push things faster forward because it demonstrates new unique use cases also for KWin scripting.

But the main thing is that I tried to change the shortcut to trigger the script to something else from the right-click menu of the plasmoid and it does not work. So at the moment I can only use the Ctrl+Meta+Z shortcut. How to change it?

Well I 've noticed a few days before that it can not be done from the System Settings yet. What you can do is to change it by hand in the QML code. If you installed the kwin script as a simple user through "GHNS or plasmapkg -i" then open file: ~/.kde4/share/apps/kwin/scripts/workflow/contents/ui/Activities2.qml

in line: registerShortcut("WorkFlow: KWin Script", "", "Meta+Ctrl+Z", function() {

set your desired shortcut and relogin... That's it...

Just above it there is way to register a hot corner but I have disabled it because it doesnt work pretty well yet...

bmihaila commented 11 years ago

Yep was thinking it is a KDE related shortcoming. The scripting APIs are not yet developed fully. On a similar thing is that the kwin script seems to sometimes make KWin freeze but I think it might be related to raster and/or the graphics drivers cause I had similar issues before but they seemed gone since a while. Now the KWin script seems to expose them again but well I have my workarounds to kill and restart KWin since the old times.

Well I 've noticed a few days before that it can not be done from the System Settings yet. What you can do is to change it by hand in the QML code. If you installed the kwin script as a simple user through "GHNS or plasmapkg -i" then open file: ~/.kde4/share/apps/kwin/scripts/workflow/contents/ui/Activities2.qml in line: registerShortcut("WorkFlow: KWin Script", "", "Meta+Ctrl+Z", function() {

Actually, it can be done. I first changed it in the sources like you said and then realized that it still did not change from the old one "Meta+Ctrl+Z" even after restarting everything. So after looking where the old shortcut is still saved I found it in System Settings, Global Shortcuts, KWin. It has to be changed from there. What is still weird is that setting the shortcut in the right-click menu of the launcher plasmoid does not work. It should anyway trigger the same even as clicking the plasmoid icon, shouldn't it? The last one opens the KWin script but not the shortcut.

Btw, the console output gives some warnings that you might want to fix:

systemsettings(4283) KShortcutsEditorItem::KShortcutsEditorItem: Action without text! "WorkFlow: KWin Script"

and also for the plasmoid

systemsettings(4283) KShortcutsEditorItem::KShortcutsEditorItem: Action without text! "WorkFlow: Next Activity"

psifidotos commented 11 years ago

Actually, it can be done. I first changed it in the sources like you said and then realized that it still did not change from the old one "Meta+Ctrl+Z" even after restarting everything. So after looking where the old shortcut is still saved I found it in System Settings, Global Shortcuts, KWin. It has to be changed from there.

Fantastic... :), so there is no issue for the scipt for the shortcut triggering then... :)

What is still weird is that setting the shortcut in the right-click menu of the launcher plasmoid does not work. It should anyway trigger the same even as clicking the plasmoid icon, shouldn't it?

Hmmm, I was hoping for this to work out of the box but probably it doesnt... :) I must have a look for it... Please open a separate issue to remember it in the kWorkFlowSL issue list... :)