search

psifidotos / latte-indicator-unity

Unity style indicator for Latte Dock
GNU General Public License v2.0
11 stars 1 forks source link

Add a slider for the background glow #4

Closed sdfjsfjaei-hans closed 5 years ago

sdfjsfjaei-hans commented 5 years ago

I think the dock might look even better with a little less (or possibly no) glow when using flat icons / themes, so a slider would be very useful. Basically the slider would determine the alpha value of the glow. (0 = no glow, 0.5 = half glow, 1 = full glow, etc.)

Thanks again for the awesome indicator! :+1:

psifidotos commented 5 years ago

has already implemented in master version... with values: 0% - 100%

image

sdfjsfjaei-hans commented 5 years ago

Awesome, thanks!

sdfjsfjaei-hans commented 5 years ago

@psifidotos Hey just a question: When will it come to the KDE store and does it update automatically?

psifidotos commented 5 years ago

@psifidotos Hey just a question: When will it come to the KDE store and does it update automatically?

when I have time :) you will be able it exactly like what you did to download it from kde store, now the button in there instead of Download it will say Update

sdfjsfjaei-hans commented 5 years ago

Okay, just saw the plugin was updated a week ago.

So I have updated the plugin (and just checked that there really is no update anymore), but weirdly enough, I can't find the glow option.

This is what my settings look like (can't scroll down any further):

Untitled

I don't know if it matters, but Type is set to Dock (instead of Panel).

I'm using the most recent master version of Latte dock.

psifidotos commented 5 years ago

this is the current version... Have you updated the Unity Indicator for inside Latte and restart Latte afterwards?

image

sdfjsfjaei-hans commented 5 years ago

Weird.. I did restart it. I have now done it again from the command line with --replace and now I can see the new options. Thanks!

Two things I noticed when the background glow is at 0%:

  1. I was wrong about it looking better with no glow when using flat icons (I really like it at 75%)
  2. The background seems a bit too dark / low contrast

unity-latte

Maybe it would look better if the background color + glow were combined: (pseudo code)

actualGlowColor = alpha * glowColor

MAX_GLOW_MIX_RATIO = 0.33
backgroundColor = (1 - alpha) * MAX_GLOW_MIX_RATIO * glowColor + calcBgColorFor(appIcon)

where alpha = Background glow percentage currently in the Unity indicator options (1 = 100%)

so the lower you'd set the the glow %, the less visible the glow would be, but the more the glow color would be mixed with the normal background color (capped here at 33%).

But maybe I missed something and this doesn't make any sense.

Either way, it's pretty good! :+1: