use pixel sixe icons

[varlesh]

Maybe better use standard pixel size value on slider? 16px, 22px, 32px, 48px, 64px, 128px and 256px. It's comfortably. Also i noticed icons always blurred on widget - icons not pixel alignment.

[varlesh]

Really 0px (on slider) - that not 48px (icons bigger). 48px that -1px Please compare: 0px:

-1px:

[psifidotos]

Using the default sizes, it would solve this jump in the appearance...

This jump (for 1px.) comes because I use PlasmaCore.IconItem in order to create the buffers.. And IconItem can not take intermediate values below 48px. just the default ones...

For my system I use as a Panel icon size the 64px. so I can shrink the icons from 48px. to 64px with no problem.

But changing this setting in the dialog in order for the user to choose just from the default ones, it would be much better I think...

[psifidotos]

--- "Also i noticed icons always blurred on widget"

can you explain me this also?

[varlesh]

--- "Also i noticed icons always blurred on widget"

if enable shadow - icons increase size and not have pixel alignment - blurred.

With shadow (-1px):

No shadow (-1px):

[psifidotos]

with shadows enabled the image buffers are used and use exactly the correct pixel size, with no shadows enabled IconItem element of Plasma is used and this is the reason of the difference...

with no shadows enabled changing the pixel size in negative values the icons decrease their size in steps..

12,24,32,48,64

also with no shadows enabled the animation is broken, it creates jump steps...

-- One way to solve this is to force shadows, I dont know for how many users no shadows is needed, and changing the settings from small increase and decrease (+1, -1) to a list of the default sizes, should also resolve this...

[varlesh]

Note: 12px and 24px not used on KDE. For example Oxygen icon theme (as standart) - use only 16px, 22px, 32px, 48px, 64px, 128px and 256px.

[varlesh]

Because Breeze icon theme not completed - have only 48px icon size

[psifidotos]

because of these differences in themes i will keep the same way to configure the icon size but I will update the internal code in order to do proper placement and fixing animations for no shadows choice...

First tests are ok... I am using Papirus icon theme in order to debug this...

[varlesh]

Please open, because not fixed. I like you dock, it's really very cool, but icons blurred. Why icons not used fixed size 16px, 22px, 32px, 48px, 64px, 128px and 256px? Compare with tasks on fullscreen mode. Tasks (48px) - NowDock (0px) - yes, icons not blurred, but this not 48px size - it's maybe 64px (really maximize32px): Tasks (48px) - NowDock (-8px): Tasks (32px) - NowDock (-24px): For example with Dolphin icon: You see, icons on NowDock blurred

[psifidotos]

1) I cant see any blurring in icons... I only see clearer contrast for Tasks because they use the dark panel beside them.. Add Icon Tasks in the Desktop with Now Dock above it... In order to compare... And try to use the same icon size... Let's see then...

2) What are the default icon sizes? I have seen so many themes with different sizes... 12,22,24,32,36,48,64,128,256

should I add all these? or should I benefit more a specific theme? it's a difficult decision...

[varlesh]

1) Ok, see (open on new tab fullscreen mode)

2) Size for icon will be hardcoded really. Usually on KDE use 16, 22, 32, 48, 64,128, 256 for GTK DE 16, 24, 32, 48,64,128,256. Will be better use universal variant - 16,22,24,32,48,64,128,256.

[varlesh]

@psifidotos You see all icons blurred on NowDock? Maybe on dock use only one size, for example 32px, and scaling program method. Why -24px less then -32px, but -16px and -8px have almost equally one size on NowDock. Dock not use original size icons.

[psifidotos]

How can I debug this??? You should help me because my eye is very difficult to catch it....

I should describe you the internal... as a graphic designer you could understand what is probably happening...

1) The issue is blurring right? Not the icon sizes... correct? the icon sizes for this development cycle I am not interested in correcting it but the blurring is important... The user to have eye craspness...

Code internals... The zoom effect is costly so I have to use buffers and shadows also is a bit costly... So what I do in the internals is the following...

the user chooses its preferred icon size, because the task is going to be zoomed at some I take an Image of a double size in order to show to the user... That image grows and shrinks....

In the default state this Image is in its half size, so this could be the blurring we are seeing here...

Does it make any sense? How to solve this, is a bit trickky...

What I could do for a start is to take the real Image in the real user preferred icon size, in order to check if this blur still exists... If it doesnt we can see what Image we will show for the zoomed item...

[psifidotos]

One idea also... What are your settings in icon sizes in plasma's systemsettings?

the issue with the bigger icons in lower values does not appear in my system... e.g. -24 to -32

[varlesh]

Zoom will be blurred icons always - it's normaly. But default icon (not zoomed) will be look as original icon on icon theme. Better create and check dock with full icon theme, for example Oxygen (have all needed icon sizes and standard icon theme for KDE): Also for compare and check dock work you can use Plank. run plank from terminal and change icon size (we need only 16, 22, 32, 48, 64,128, 256.... note: on plank not available 16px and 22px icon sizes) plank --preferences

[psifidotos]

-24px

-32px

[varlesh]

@psifidotos some icons (if you use Papirus) have line/lines, for example Dolphin, libreoffice icons. See your screens libreoffice icon have blurred line

[varlesh]

[varlesh]

NOTE: On papirus (kde-version) available for apps 16,22,32,48 and 64 px sizes.

[psifidotos]

I opened plank to compare.... You are right... My icons are blurred... Plank's are very craspy... I have to investigate... Just using the default sizes may not solve this...

[varlesh]

For example Plank. 48px 32px

[psifidotos]

can you check the sharpness brach for this please? even though now the zoom effect looks blurred... I must find a way to update it...

[varlesh]

Yes, yes - now all fine. It's very good ))

[varlesh]

@psifidotos Big thx, look cool. I like it 👍 All size looks fine!!!

[varlesh]

Blurred zoom - it's normally, because there is a shift pixels.

[psifidotos]

@varlesh :+1: Thank you for your support and patience... :)

it really looks lovely!!!

... for zooming blurring solution I might try to create a second buffer which is going to have an Image in the maximum zoomed area and use that for zooming.... it may help but I cant know yet...