psifidotos / nowdock-plasmoid

Plasma 5 plasmoid that creates a plank or mac style effect for tasks
GNU General Public License v3.0
37 stars 3 forks source link

Icon sort/order #31

Closed alexjp closed 7 years ago

alexjp commented 7 years ago

Hi,

I have two "all activcities" launchers, dolphin and konsole, and they are always the top ones.

Sometimes, "launched launchers" will go up to the top. Is it possible to keep ordering ?

Example:

screenshot_20160907_084855

In this window, kmail is openned on my other monitor. It is not normally on the top, but because its openned, it got into the top. This usually happens when i switch activities and came back.

psifidotos commented 7 years ago

I have noticed also... I dont know the answer actually... the behavior we see is that the opened launchers are ordered first... we will see what is going on...

This is based a lot on how libtaskmanager decides to order the launchers after a launcher list update has happened...

alexjp commented 7 years ago

I actually had this bug a while ago : https://bugs.kde.org/show_bug.cgi?id=364212

But its supposed to be fixed, at least on normal taskmanager seems to be.

psifidotos commented 7 years ago

but normal taskmanager is not making a launchers list update in every activity switching...

alexjp commented 7 years ago

There was a bug in the first versions of the new taskmanager, where launching an app would make it go into the left.

but normal taskmanager is not making a launchers list update in every activity switching...

I dunno if its doing it or not, but may be doing it, only its only seen on nowdock because of the animations.

One common cause is that they are ordered, but when switching activities they lose their order.

When i have a bit of time i will check the taskmanager git log and try to check what was done.

psifidotos commented 7 years ago

I dunno if its doing it or not, but may be doing it, only its only seen on nowdock because of the animations.

it isnt the taskmanager which is doing it... it is the nowdock plasmoid...

I have implemented to update the whole launcher list in each activity switching... I thought that this would be the only way to keep the ordering right...

I could try to make removals and additions for launchers between activity switching instead of full initialization but I fear that the activity launchers order will break probably...

psifidotos commented 7 years ago

this needs research, in order to understand if this is from my current implementation or from the libtaskmanager not taking into account the use case (update launchers list after the first publishing)

psifidotos commented 7 years ago

@alexjp can you please test that this is happening also for the lanchers which are "Not On All Activities" ?

alexjp commented 7 years ago

@psifidotos from my experience, this is happening especially on launchers which are "not on all activities", since I only have 2 "All activities" launchers.

Right now I have an example of "Not On All Activities" launchers, on one activity it became first icon, and on another, it became the last icon.

psifidotos commented 7 years ago

@kupiqu , actually I can fix this for the startup... But, the only way to workaround this when changing activities an initialization is needed... Which means that I should hide all icons and then show them again...

kupiqu commented 7 years ago

I think this would be ok, wouldn't it? I mean plasma desktop is being reload when this happens, so one may be tolerant about transient adjustments that need to be done to come back to normal behavior, in my opinion...

kupiqu commented 7 years ago

Was talking about startup, about activity changes, I'm not sure, although personally I would prefer to keep sorting at all cost, including re-initialization :/

psifidotos commented 7 years ago

... this is a mess ... check the sortorder branch... This is upstream... Providing a different launcher list makes the task model to behave like this... My opinion is that it shouldnt... I am just trying to workaround this behavior... I am not that positive that this will succeed...

kupiqu commented 7 years ago

I tested it. It doesn't seem to work for me.

If this is upstream, I would just forget about it for now

psifidotos commented 7 years ago

From nowhere... I probably found a workaround !!! Please check branch sortorder2, it should fix this in most cases.... The only issue is that OnAllActivities launchers can not be mixed yet with "Spesific Activity" ones... So the ordering for them would be...

"OnAllActivities" correct ordering, "Spesific Activities" correct ordering, rest of windows...

psifidotos commented 7 years ago

@kupiqu please check again sortorder2....

kupiqu commented 7 years ago

It still does weird things in my system, icons missing, and on hovering things move a bit crazy up and down, with empty spaces :/

All my applications appear in all activities, for the case this is useful

psifidotos commented 7 years ago

@kupiqu are you sure you are using sortorder2 ? this is different than the sortorder...

psifidotos commented 7 years ago

@kupiqu I have just uploaded a small fix that may fix things for you...

kupiqu commented 7 years ago

Yes, I'm using sortorder2. Unfortunately, it doesn't work properly here yet. Some icons appear now on top of others.

psifidotos commented 7 years ago

in my system works perfectly... maybe an initialization? remove all launchers and try again?

psifidotos commented 7 years ago

and maybe a screenshot...

kupiqu commented 7 years ago

Will test in a new plasmoid and will let you know

alexjp commented 7 years ago

in my system works perfectly... maybe an initialization? remove all launchers and try again?

I didn't do alot of testing, just openning launchers from the 3 kinds ( all activities, this activity , one time launcher ) and switching activities like mad , and everything seemed ok, all launchers were in the right order.

psifidotos commented 7 years ago

@alexjp I think it is possible now with the new fix to support mixing all activities launchers and per activity launchers and the internals could remember their orders per activity... That needs an update in the internals but I think it can be done... What do you think?

@kupiqu did you have any update in this? There is a chance also that the new plasmoid version from sortorder2 has been updated correctly in your system... It sometimes happens... You could also try to remove the plasmoid and then re-install it...

alexjp commented 7 years ago

@alexjp I think it is possible now with the new fix to support mixing all activities launchers and per activity launchers and the internals could remember their orders per activity... That needs an update in the internals but I think it can be done... What do you think?

Seems to already work on the branch sortorder2 .... haven't catched any problem till now

psifidotos commented 7 years ago

@alexjp what I am describing is an advance situation :) for example .... I have 3 launchers, a firefox(all activities), a dolphin (all activities) and a kwrite(specific activity). I drag kwrite between firefox and dolphin... After the activity change the launchers are ordered based on their type, so it will be firefox, dolphin, kwrite...

I think that because of the new fix it would be possible to have (per activity) launchers between (all activities) launchers, and Now Dock would restore their ordering even in this advance situation...

alexjp commented 7 years ago

@psifidotos sorry, misunderstood ... i thought you were talking about mixing them as in having them on the dock and them being ordered. Never though on actually putting a "single activity launcher" between "all activity launchers".

psifidotos commented 7 years ago

@alexjp me too... :) I like the ordering of being first the global launchers and after them following the specific activity's ones.... I am just taking opinions.. :) I can leave this for a later release (above 0.4) if the users find it useful...

psifidotos commented 7 years ago

eveything in master branches for panel and plasmoid and small fixes ... Last days before 0.3 release... :-)

kupiqu commented 7 years ago

Sorry, I had to deal with a deadline, and won't be able to test this further until Tomorrow (still experiencing issues, but this might be because my plasma desktop rc file is quite messy, I will try to start it from scratch and will see).

psifidotos commented 7 years ago

:+1: let me know @kupiqu

psifidotos commented 7 years ago

@kupiqu, and please uninstall every prior version of the plasmoid and the panel before using the master branches!! There is a change in their names that could create two different instances for each one...

kupiqu commented 7 years ago

I reconfigured my plasma desktop from scratch and used last master versions of nowdock panel and plasmoid, however, I am experiencing the same behavior.

Reached this point, I'm not sure whether I explained my issue quite properly. I am referring to the following case, please try to reproduce:

  1. Open some apps that are launchers in nowdock plasmoid
  2. kquitapp plasmashell
  3. kstart plasmashell

expected behavior:

seen behavior:

please see screenshots for an example:

screenshot_20160917_025706 screenshot_20160917_025601

Please note in the example how Kate's icon has moved and now overlaps Konqueror's icon.

psifidotos commented 7 years ago

@kupiqu which of them are the launchers?

psifidotos commented 7 years ago

@kupiqu, as I see it everything is in place except the konqueror and kwrite that have swaped positions... The question is why the konqueror icon is not shown...

kupiqu commented 7 years ago

Re launchers: First one is system settings and last is spotify.

It is not that konqueror icon is not showing, but it is behind kate's icon and the other is empty. As I said, this is an example, and it is quite random, sometimes icons even go out of the plasmoid and overlap e.g. the application launcher (kde icon). I know it is an overlap because you see the other icon behind (unfortunately in previous example, kate's icon occupies all space and you cannot see konqueror's icon behind).

kupiqu commented 7 years ago

Would it help if I copy the settings of nowdock in plasma-org.kde.plasma.desktop-appletsrc and you add those to your file?

Perhaps you won't have some apps, but you can remove those before inserting the settings in plasma-org.kde.plasma.desktop-appletsrc. I think it would be the closest we can get to have something similar in your and my system.

[Containments][69] activityId= formfactor=3 immutability=1 lastScreen=0 location=5 plugin=org.kde.store.nowdock.panel wallpaperplugin=org.kde.image

[Containments][69][Applets][71] immutability=1 plugin=org.kde.milou

[Containments][69][Applets][72] immutability=1 plugin=org.kde.plasma.kicker

[Containments][69][Applets][72][Configuration][General] favoriteApps=systemsettings.desktop,org.kde.dolphin.desktop,org.kde.konsole.desktop,org.kde.kate.desktop,kde4-kile.desktop,org.kde.kontact.desktop,konqueror.desktop,chromium-browser.desktop,org.kde.dragonplayer.desktop,smplayer.desktop,spotify.desktop

[Containments][69][Applets][73] immutability=1 plugin=org.kde.store.nowdock.plasmoid

[Containments][69][Applets][73][Configuration][ConfigDialog] DialogHeight=780 DialogWidth=1040

[Containments][69][Applets][73][Configuration][General] dotsOnActive=true isInNowDockPanel=true launchers=multi;*;11;file:///usr/share/applications/systemsettings.desktop;file:///usr/share/applications/org.kde.dolphin.desktop;file:///usr/share/applications/org.kde.konsole.desktop;file:///usr/share/applications/org.kde.kate.desktop;file:///usr/share/applications/kde4/kile.desktop;file:///usr/share/applications/org.kde.kontact.desktop;file:///home/jsardid/.local/share/applications/konqueror.desktop;file:///usr/share/applications/chromium-browser.desktop;file:///usr/share/applications/org.kde.dragonplayer.desktop;file:///usr/share/applications/smplayer.desktop;file:///home/jsardid/.local/share/applications/spotify.desktop showGlow=false showOnlyCurrentActivity=false showShadows=false showToolTips=true threeColorsWindows=true

[Containments][69][Applets][74] immutability=1 plugin=cqcb.plasma.webslice

[Containments][69][Applets][74][Configuration][ConfigDialog] DialogHeight=780 DialogWidth=1040

[Containments][69][Applets][74][Configuration][General] buttonBehaviour=true displaySiteBehaviour=false websliceUrl=http://192.168.0.1

[Containments][69][Applets][75] immutability=1 plugin=org.kde.plasma.colorpicker

[Containments][69][Applets][76] immutability=1 plugin=cqcb.plasma.webslice

[Containments][69][Applets][76][Configuration][ConfigDialog] DialogHeight=780 DialogWidth=1040

[Containments][69][Applets][76][Configuration][General] buttonBehaviour=true displaySiteBehaviour=false websliceUrl=http://192.168.0.1

[Containments][69][ConfigDialog] DialogHeight=1440 DialogWidth=276

[Containments][69][General] appletOrder=71;72;73;74;75;76 automaticIconSize=true panelPosition=Top panelSize=4 smallAutomaticIconJumps=true useThemePanel=true zoomLevel=5

kupiqu commented 7 years ago

I am just trying to help you reproduce the issue. Things that might be involved in some weird fashion:

Or perhaps some other issue that I cannot even imagine...

psifidotos commented 7 years ago

@kupiqu, this is not easy ... I tried your configuration already and I didnt have any issues... I use opensuse with plasma 5.7...

let's try something else... try please the blanks branch for the plasmoid and tell if you have same issues... In this branch I have disabled the reordering of launchers.. your launchers will no appear in the correct order but at least we will know where is the problem...

kupiqu commented 7 years ago

I'm going to try it, but please note that my problem was not present before introducing the feature to reorder launchers (which, if I recall properly, I suggested)

kupiqu commented 7 years ago

Another example:

screenshot_20160917_090500
psifidotos commented 7 years ago

it is important to try it, because it you dont have any issues then this means that reordering in your system happens in a time that breaks your experience... Currently the reordering happens just before adding the launcher...

kupiqu commented 7 years ago

Without reordering I don't see any issue (besides the obvious of the ordering itself, of course):

screenshot_20160917_091406
kupiqu commented 7 years ago

I will keep the plasmoid in this branch for now until the issue is fixed :)

But let me know if you want me to test more...

psifidotos commented 7 years ago

ok... let's try to make the reordering after the launcher has ended its animation...

please, try again!

psifidotos commented 7 years ago

@kupiqu dont bother... doesnt help....

kupiqu commented 7 years ago

did I say sth wrong? if so, it was unintentional...

psifidotos commented 7 years ago

@kupiqu no, no... I was referring to the previous commit in @blank branch... I was hopping to help but it didnt...

kupiqu commented 7 years ago

Ok let me know if you want me to test at at some point :)

psifidotos commented 7 years ago

I am trying to change a bit the architecture... I will have something in a while...